Conversation
pump9918
approved these changes
Dec 22, 2023
pump9918
left a comment
pump9918
left a comment
There was a problem hiding this comment.
이미 코드가 깔끔해서 StateFlow로도 금방 바꾸네요
종강 축하~~~ 앱잼 가자~~
| else -> {} | ||
| } | ||
| } | ||
| }.launchIn(lifecycleScope) |
| _signInState.value = UiState.Success(authInfo) | ||
| }.onFailure { throwable -> | ||
| _signInResult.value = throwable.message?.let { UiState.Failure(it) } | ||
| Timber.e(throwable.message) |
HAJIEUN02
approved these changes
Dec 23, 2023
| import org.sopt.dosopttemplate.data.entity.auth.AuthInfo | ||
| import org.sopt.dosopttemplate.data.repository.auth.AuthRepository | ||
| import org.sopt.dosopttemplate.util.UiState | ||
| import timber.log.Timber |
There was a problem hiding this comment.
log가 아니라 timber를 사용해야 하는 이유가 따로 있나요?? 릴리즈했을 땐 자동으로 사라지는건가여 timber는??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📷 screenshot
결과는 같기 때문에 생략하였습니다
📝 Work Desciption
📚 Reference 혹은 궁금한 사항들