Skip to content

Refactor [#7] mvvm 리팩토링 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chaentopia wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Refactor [#7] mvvm 리팩토링 #8

chaentopia wants to merge 6 commits into from

Conversation

@chaentopia
Copy link
Collaborator

@chaentopia chaentopia commented Dec 13, 2023

⛏ 작업 내용

  • 세미나에서 학습한 mvvm 패턴을 통해서 과제 리팩토링을 진행했습니다.
  • 화면은 기존과 같습니다.

📌 PR Point!

  • 아직 mvvm이 어색해서 ^^ 어디까지 ViewModel로 칠 수 있는지 좀 애매한 것 같아요... UIKit을 import 하지 않는 선에서 써야 하는지... 일단 개인적으로 mvvm을 쓰면 확실히 코드가 깔끔해지고 알아보기 쉬워진다는 건 느낀 것 같습니다. 다른 분들이 쓰는 mvvm도 한번 찾아봐야겠다는 생각을 했답니다..

📸 스크린샷

구현 내용 스크린샷
화면종류 Simulator Screen Recording - iPhone 15 - 2023-12-13 at 18 06 49

✅ Issue

Resolved #7

@chaentopia chaentopia self-assigned this Dec 13, 2023
@ena-isme
Copy link

ena-isme commented Dec 15, 2023

멋있씁니당 수고하셨어여

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Genesis2010 Genesis2010 Awaiting requested review from Genesis2010

@HELLOHIDI HELLOHIDI Awaiting requested review from HELLOHIDI

@boogios boogios Awaiting requested review from boogios

@alstn38 alstn38 Awaiting requested review from alstn38

@hyowon612 hyowon612 Awaiting requested review from hyowon612

@boyeon0119 boyeon0119 Awaiting requested review from boyeon0119

@ahra1221 ahra1221 Awaiting requested review from ahra1221

@frohsch frohsch Awaiting requested review from frohsch

@Heyjooo Heyjooo Awaiting requested review from Heyjooo

@0seoYun 0seoYun Awaiting requested review from 0seoYun

@Guryss Guryss Awaiting requested review from Guryss

@ena-isme ena-isme Awaiting requested review from ena-isme

@binisnil binisnil Awaiting requested review from binisnil

@hyoring030 hyoring030 Awaiting requested review from hyoring030

@bangMinjI98 bangMinjI98 Awaiting requested review from bangMinjI98

Assignees

@chaentopia chaentopia

Labels

Refactor 과제

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Refactor] MVVM 패턴 적용

3 participants

@chaentopia @ena-isme