Skip to content

Conversation

@chkim-usgs
Copy link
Collaborator

Only merge after the new cspice is released (9/22/25).

Built and tested incoming cspice-feedstock PR that uses new cmake recipe. Got it installed, built SpiceQL, and ran SpiceQL tests successfully.

Here's my updated cmake command I had to run with the new cspice:

cmake .. -GNinja -DCMAKE_INSTALL_PREFIX=$CONDA_PREFIX -DSPICEQL_BUILD_TESTS=ON -DCMAKE_PREFIX_PATH=$CONDA_PREFIX -DPython3_ROOT_DIR=$CONDA_PREFIX -DPython3_FIND_STRATEGY=LOCATION

Reference: DOI-USGS/ISIS3#5879
Related: #102

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

CMakeLists.txt Outdated
PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/SpiceQL/include>
$<INSTALL_INTERFACE:include>
${CSPICE_INCLUDE_DIRS}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be "Public"? Can it be "Private"? I just worry about polluting the includes for other packages

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's ok, I'll change it to private.

@acpaquette acpaquette merged commit 2c0bf64 into DOI-USGS:main Sep 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants