Skip to content

ALE default log level INFO -> ERROR #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrcain-usgs wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ALE default log level INFO -> ERROR #679

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d1bcc4
ALE default log level INFO -> ERROR
jrcain-usgs Dec 2, 2025
66f49c6
changelog entry default log level error
jrcain-usgs Dec 2, 2025
ee80551
reversed verbosity comparison
jrcain-usgs Dec 3, 2025
ef0b70e
tests call default to verbose false
jrcain-usgs Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ release.

## [Unreleased]

- Sets ALE's default log level to ERROR instead of INFO, which was too verbose. [#679](https://github.com/DOI-USGS/ale/pull/679)

## [1.0.2]

- Fixed bug where generic CH2 kernels were using for TMC-2 [#672](https://github.com/DOI-USGS/ale/pull/672)
Expand Down
4 changes: 2 additions & 2 deletions ale/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
logger.addHandler(handler)
logger.propagate = False

log_level = os.environ.get("ALE_LOG_LEVEL", "INFO").upper()
logger.setLevel(getattr(logging, log_level, logging.INFO))
log_level = os.environ.get("ALE_LOG_LEVEL", "ERROR").upper()
logger.setLevel(getattr(logging, log_level, logging.ERROR))

logger.debug(f"ALE version: {__version__}")
logger.debug(f"ALE python version: {sys.version.split(' ')[0]}")
Expand Down
10 changes: 5 additions & 5 deletions ale/isd_generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@ def main():
)
args = parser.parse_args()

log_level = logging.INFO
log_level = logging.ERROR
if args.verbose:
log_level = logging.WARNING
log_level = logging.INFO

logger.setLevel(log_level)

Expand Down Expand Up @@ -203,7 +203,7 @@ def file_to_isd(
out: os.PathLike = None,
radii: list = None,
kernels: list = None,
log_level=logging.WARNING,
log_level=logging.ERROR,
compress=False,
only_isis_spice=False,
only_naif_spice=False,
Expand Down Expand Up @@ -250,9 +250,9 @@ def file_to_isd(
if kernels is not None:
kernels = [str(PurePath(p)) for p in kernels]
props["kernels"] = kernels
usgscsm_str = ale.loads(file, props=props, verbose=log_level>logging.INFO, only_isis_spice=only_isis_spice, only_naif_spice=only_naif_spice)
usgscsm_str = ale.loads(file, props=props, verbose=log_level<=logging.INFO, only_isis_spice=only_isis_spice, only_naif_spice=only_naif_spice)
else:
usgscsm_str = ale.loads(file, props=props, verbose=log_level>logging.INFO, only_isis_spice=only_isis_spice, only_naif_spice=only_naif_spice)
usgscsm_str = ale.loads(file, props=props, verbose=log_level<=logging.INFO, only_isis_spice=only_isis_spice, only_naif_spice=only_naif_spice)

if radii is not None:
# first convert to kilometers for ISD
Expand Down
Loading