Skip to content

Conversation

@ldecicco-USGS
Copy link
Collaborator

No description provided.

@ldecicco-USGS ldecicco-USGS requested a review from ehinman August 7, 2025 14:29
@ldecicco-USGS
Copy link
Collaborator Author

@ehinman or @jzemmels - let me know if either of you could take a look. We need to submit to CRAN (due to the broken test) by Aug. 25, I'm shooting for 8/18

@ehinman
Copy link
Collaborator

ehinman commented Aug 7, 2025

@ldecicco-USGS I can take a look this week.

Copy link
Collaborator

@ehinman ehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @ldecicco-USGS. I found a few typos in the slides, but otherwise, minor comments/suggestions. Nice work! So exciting to see new functions come online that work well.

#'
#' \donttest{
#' site <- "USGS-02238500"
#' field_data_sf <- read_waterdata_field_measurements(monitoring_location_id = site)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an explanation as to why gwlevels are considered "field measurements"? As a non-hydrologist, this seems kind of random.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's basically all discrete data that does go to the water quality portal.

#' "USGS-263819081585801"),
#' parameter_code = c("62611", "72019"))
#'
#' old_df <- read_waterdata_field_measurements(monitoring_location_id = "USGS-425957088141001",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be helpful to have a surface water example, too. These examples led me to check whether "field measurements" was JUST groundwater levels.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this one for fun and it returned 86 values:

test <- read_waterdata_field_measurements(
  bbox = c(-94, 36, -90, 39),
  time = "2025-07-01T00:00:00Z/..",
  parameter_code = "00060"
)


## read_waterdata HUCs

HUCs that fall within 02070010. Use the wildcard `%`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get what this means after thinking on it for a minute, but at first, I thought the function was going to return all the HUCs within 02070010, not all the sites within HUCs that start with 02070010.

@ldecicco-USGS ldecicco-USGS merged commit 7e17eea into main Aug 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants