-
Notifications
You must be signed in to change notification settings - Fork 94
Field measurements #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field measurements #812
Conversation
Field measurements
|
@ldecicco-USGS I can take a look this week. |
ehinman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @ldecicco-USGS. I found a few typos in the slides, but otherwise, minor comments/suggestions. Nice work! So exciting to see new functions come online that work well.
| #' | ||
| #' \donttest{ | ||
| #' site <- "USGS-02238500" | ||
| #' field_data_sf <- read_waterdata_field_measurements(monitoring_location_id = site) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an explanation as to why gwlevels are considered "field measurements"? As a non-hydrologist, this seems kind of random.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's basically all discrete data that does go to the water quality portal.
| #' "USGS-263819081585801"), | ||
| #' parameter_code = c("62611", "72019")) | ||
| #' | ||
| #' old_df <- read_waterdata_field_measurements(monitoring_location_id = "USGS-425957088141001", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be helpful to have a surface water example, too. These examples led me to check whether "field measurements" was JUST groundwater levels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this one for fun and it returned 86 values:
test <- read_waterdata_field_measurements(
bbox = c(-94, 36, -90, 39),
time = "2025-07-01T00:00:00Z/..",
parameter_code = "00060"
)
|
|
||
| ## read_waterdata HUCs | ||
|
|
||
| HUCs that fall within 02070010. Use the wildcard `%` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get what this means after thinking on it for a minute, but at first, I thought the function was going to return all the HUCs within 02070010, not all the sites within HUCs that start with 02070010.
Co-authored-by: Elise Hinman <[email protected]>
Co-authored-by: Elise Hinman <[email protected]>
Co-authored-by: Elise Hinman <[email protected]>
Co-authored-by: Elise Hinman <[email protected]>
Co-authored-by: Elise Hinman <[email protected]>
Co-authored-by: Elise Hinman <[email protected]>
Co-authored-by: Elise Hinman <[email protected]>
No description provided.