NLDI client update fixes #844#845
Merged
ldecicco-USGS merged 1 commit intoDOI-USGS:developfrom Jan 20, 2026
Merged
Conversation
dblodgett-usgs
temporarily deployed
to
CI_config
GitHub Actions
Inactive
dblodgett-usgs
had a problem deploying
to
CI_config
GitHub Actions
Failure
Collaborator
|
We're trying to stage all changes that will eventually be sent to CRAN in the develop branch. When I'm about ready to submit, I'll make a PR for develop -> main to verify everything looks good. That should actually be this week because we want to get "continuous" out there asap. |
Contributor
Author
|
Great. I have an nhdplusTools release going to CRAN this week that will work with either version of the code. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working to get the agency code IDs into the overall NLDI client and these changes are needed for the way I call this code from nhdplusTools. No change to the tests here and generally relaxes some of the "special" handling that was in here.