Skip to content

MakePolys bug fixes and improvements #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
freewheelCarto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MakePolys bug fixes and improvements #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 71 additions & 9 deletions Scripts/GeMS_MakePolys3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,40 @@ def sql_list(var):
arcpy.AddMessage("Saving MapUnitPolys")
arcpy.management.Copy(mup, guf.getSaveName(mup))


# ### - TANNER ARRINGTON CHANGES - 6/30/2025 - ### #
# ################################################ #

# ORIGINAL CODE DOES NOT TAKE INTO ACCOUNT NULL VALUES IN iSConcealed.
# Either need to report null values, put null in the where clause, or both

# make selection set without concealed lines
fld = arcpy.AddFieldDelimiters(caf, "IsConcealed")
where = f"LOWER({fld}) NOT IN ('y', 'yes')"

# TA - original where clause below that does not consider null
# where = f"LOWER({fld}) NOT IN ('y', 'yes')"

# OPTION 1 - where clause that DOES consider null values, along with those that aren't yes.No reporting on nulls
# where = f"LOWER({fld}) NOT IN ('y','yes') OR LOWER({fld}) IS NULL"

# OPTION 2 - two separate where clauses; first, just select nulls and return a warning that they are being used in the make polys
# then run the whole clause, with nulls and other values, to get full selection for the make polys.
where1 = f"LOWER({fld}) IS NULL"
where2 = f"LOWER({fld}) NOT IN ('y','yes') OR LOWER({fld}) IS NULL"

arcpy.AddMessage("Looking for Null values in IsConcealed")
contacts = arcpy.management.SelectLayerByAttribute(caf, where_clause=where1)
nullCount = int(str(arcpy.management.GetCount(contacts)))
if nullCount > 0:
arcpy.AddWarning(f"There are {nullCount} Null values in the isConcealed field. These were considered non-concealed lines and used to make polygons.")

arcpy.AddMessage("Selecting all non-concealed lines")
contacts = arcpy.management.SelectLayerByAttribute(caf, where_clause=where)
contacts = arcpy.management.SelectLayerByAttribute(caf, where_clause=where2)
arcpy.AddMessage(int(str(arcpy.management.GetCount(contacts))))

# ############################## #
# ### END TANNER SUGGESTIONS ### #


# make new polys
new_polys = r"memory\mup"
Expand All @@ -132,7 +161,8 @@ def sql_list(var):

arcpy.AddMessage("Building new map unit polygons in memory")
arcpy.management.FeatureToPolygon(contacts, new_polys, label_features=label_points)

arcpy.AddMessage(arcpy.management.GetCount(new_polys))

# truncate MapUnitPolys
arcpy.AddMessage(f"Emptying {short_mup}")
arcpy.management.TruncateTable(mup)
Expand Down Expand Up @@ -252,13 +282,30 @@ def sql_list(var):
]

# look for multiple label points in the new polygons
mup_inter_labels = r"memory\mup_inter_labels"
arcpy.analysis.Intersect([mup, label_points], mup_inter_labels)
oids = [
row[0] for row in arcpy.da.SearchCursor(mup_inter_labels, f"FID_{short_mup}")
]
dup_oids = set([x for x in oids if oids.count(x) > 1])

# ### - TANNER ARRINGTON CHANGES - 6/30/2025 - ### #
# ################################################ #

# There is a case where user does not have label points, and does not have existing MapUnitPolys.
# In this case, the tool fails while running reporting mode, because it tries to run the intersect below but
# there is no label_points defined, thus tool fails.
# add this section inside a boolean against label_points

if label_points:
mup_inter_labels = r"memory\mup_inter_labels"
arcpy.analysis.Intersect([mup, label_points], mup_inter_labels)
oids = [
row[0] for row in arcpy.da.SearchCursor(mup_inter_labels, f"FID_{short_mup}")
]
dup_oids = set([x for x in oids if oids.count(x) > 1])
else:
#create an empty set because dup_oids is referenced later in the script
dup_oids = ()

# ############################# #
# ### END TANNER SUGGESTION ### #


# look for changed polygons
inter_polys = r"memory\inter_polys"
arcpy.analysis.Intersect([old_polys, mup], inter_polys)
Expand Down Expand Up @@ -295,6 +342,12 @@ def sql_list(var):
if l.longName == "Make Polys - Report Layers":
active_map.removeLayer(l)


# ### - TANNER ARRINGTON CHANGES - 6/30/2025 - ### #
# ################################################ #

# METHOD FOR ADDING AN EXISTING BLANK GROUP LAYER FILE
"""
# find genericgroup.lyrx in the \Scripts folder
this_py = Path(__file__)
scripts = this_py.parent
Expand All @@ -303,6 +356,15 @@ def sql_list(var):
# add it to the map and rename it
group = active_map.addDataFromPath(str(group_lyr))
group.name = "Make Polys - Report Layers"
"""

# METHOD FOR CREATING A NEW BLANK GROUP LAYER instead of accessing an existing layer file.
group = active_map.createGroupLayer("Make Polys - Report Layers")

# ############################## #
# ### - END TANNER CHANGES - ### #



# add report layers
# multiple label point polygons
Expand Down
97 changes: 97 additions & 0 deletions Scripts/genericgroup.lyrx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
{
"type" : "CIMLayerDocument",
"version" : "3.5.0",
"build" : 57366,
"layers" : [
"CIMPATH=Map/New_Group_Layer.json"
],
"layerDefinitions" : [
{
"type" : "CIMGroupLayer",
"name" : "genericgroup",
"uRI" : "CIMPATH=Map/New_Group_Layer.json",
"sourceModifiedTime" : {
"type" : "TimeInstant"
},
"metadataURI" : "CIMPATH=Metadata/a456638025d52e70405fc8e18068334a.xml",
"useSourceMetadata" : true,
"description" : "New Group Layer",
"layerElevation" : {
"type" : "CIMLayerElevationSurface",
"elevationSurfaceLayerURI" : "CIMPATH=Map/00870e78e9bb47a69058ac891ae0404c.json"
},
"layerType" : "Operational",
"showLegends" : true,
"visibility" : true,
"displayCacheType" : "Permanent",
"maxDisplayCacheAge" : 5,
"showPopups" : true,
"serviceLayerID" : -1,
"refreshRate" : -1,
"refreshRateUnit" : "esriTimeUnitsSeconds",
"blendingMode" : "Alpha",
"allowDrapingOnIntegratedMesh" : true,
"sublayerVisibilityMode" : "Independent"
}
],
"binaryReferences" : [
{
"type" : "CIMBinaryReference",
"uRI" : "CIMPATH=Metadata/a456638025d52e70405fc8e18068334a.xml",
"data" : "<?xml version=\"1.0\"?>\r\n<metadata xml:lang=\"en\"><Esri><CreaDate>20250627</CreaDate><CreaTime>09133300</CreaTime><ArcGISFormat>1.0</ArcGISFormat><SyncOnce>TRUE</SyncOnce></Esri><dataIdInfo><idCitation><resTitle>New Group Layer</resTitle></idCitation><idAbs>New Group Layer</idAbs><idCredit></idCredit><idPurp></idPurp><resConst><Consts><useLimit></useLimit></Consts></resConst></dataIdInfo></metadata>\r\n"
}
],
"rGBColorProfile" : "sRGB IEC61966-2.1",
"cMYKColorProfile" : "U.S. Web Coated (SWOP) v2",
"elevationSurfaceLayerDefinitions" : [
{
"type" : "CIMElevationSurfaceLayer",
"name" : "Ground",
"uRI" : "CIMPATH=Map/00870e78e9bb47a69058ac891ae0404c.json",
"sourceModifiedTime" : {
"type" : "TimeInstant"
},
"useSourceMetadata" : true,
"description" : "Ground",
"expanded" : true,
"layer3DProperties" : {
"type" : "CIM3DLayerProperties",
"castShadows" : true,
"isLayerLit" : true,
"layerFaceCulling" : "None",
"preloadTextureCutoffHigh" : 0.29999999999999999,
"preloadTextureCutoffLow" : 0.59999999999999998,
"textureCutoffHigh" : 0.29999999999999999,
"textureCutoffLow" : 0.59999999999999998,
"useCompressedTextures" : true,
"verticalExaggeration" : 1,
"exaggerationMode" : "ScaleZ",
"lighting" : "OneSideDataNormal",
"optimizeMarkerTransparency" : true
},
"layerType" : "Operational",
"showLegends" : false,
"visibility" : true,
"displayCacheType" : "Permanent",
"maxDisplayCacheAge" : 5,
"showPopups" : true,
"serviceLayerID" : -1,
"refreshRate" : -1,
"refreshRateUnit" : "esriTimeUnitsSeconds",
"blendingMode" : "Alpha",
"allowDrapingOnIntegratedMesh" : true,
"elevationMode" : "BaseGlobeSurface",
"verticalExaggeration" : 1,
"color" : {
"type" : "CIMRGBColor",
"values" : [
255,
255,
255,
100
]
},
"surfaceTINShadingMode" : "Smooth"
}
]
}