Skip to content

Fsp review#88

Open
cnell-usgs wants to merge 63 commits intomainfrom
fsp-review
Open

Fsp review#88
cnell-usgs wants to merge 63 commits intomainfrom
fsp-review

Conversation

@cnell-usgs
Copy link
Copy Markdown
Member

hanges made:

  • Restyled the navigation menu to be dropdowns:
image Screenshot 2026-03-09 at 9 46 01 PM.
  • Addressed challenges with too many cards in some sections. which made navigation on mobile tediuous. Now the sections each have a default number of items that appear (8 for viz and blogs, 75 rem for snapshots and sketches, all for series).
  • Added a an expandable button below sections that when clicked shows all the content in that section
  • Restyled to using mostly just usgs blue and source sans pro to have a consistent usgs stlye throughout
  • Made all series cards appear at same visual hierarchy, removing carousel
  • Reworked section and card components so there are 2 main section styles:
    (1) a grid that can be filtered and sizes all cards to same width (but can have different heights based on card dimensions) and (2) a grid that has standard sized cards in an even grid.
  • Moved thumbnail assets to src/assets to provide directly

Testing:

Before making this pull request, I:

  • Cleaned the code the way Vue likes it - run 'npm run lint --fix'
  • Made sure all tests run
  • Ran WAVE plugin 508 compliance tool

I can confirm this has been checked on:

  • Chrome
  • Safari
  • Edge
  • Firefox
  • Samsung Internet
  • Internet Explorer 11 (not supported, but still needs at least a working user redirect page)

@cnell-usgs cnell-usgs requested a review from elmeraa-usgs March 11, 2026 19:52
@elmeraa-usgs
Copy link
Copy Markdown
Collaborator

Nice! It looks so good on mobile too. Couple things:

What do you think about making the tags all sentence case? It feels a bit awkward to me that just "All" is sentence case and the others are lowercase. What do you think?

Screenshot 2026-03-23 at 8 40 18 AM

Anthony's blogs are in here twice.
Screenshot 2026-03-23 at 8 42 40 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants