Check for minimum password length upon self registration. #2459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
force-pushed
the
self-register-password-length
branch
from
ffe29b6 to
3cc0a54
Compare
vmcj
reviewed
Apr 14, 2024
eldering
reviewed
Apr 15, 2024
nickygerritsen
force-pushed
the
self-register-password-length
branch
from
3cc0a54 to
0f88011
Compare
meisterT
approved these changes
Apr 22, 2024
|
Probably we need to tell the user what length we expect when we present the form? Not reject it after submission with a surprise limit that was never communicated before? |
The |
vmcj
reviewed
Jun 1, 2024
nickygerritsen
force-pushed
the
self-register-password-length
branch
2 times, most recently
from
c400043 to
49143a4
Compare
nickygerritsen
force-pushed
the
self-register-password-length
branch
from
49143a4 to
3d42b76
Compare
I added an explicit help text for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2458.