Skip to content

Fix the line break in the tooltips of public statistics #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Fix the line break in the tooltips of public statistics #2622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ea3e98
Revert "ui: problem_list: fix line break"
cubercsl Jul 23, 2024
3bf3cc4
fix(frontend): The line break in the tooltips
cubercsl Jul 23, 2024
72385d7
fix(frontend): enable popover
cubercsl Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webapp/public/js/domjudge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ function setupPreviewClarification($input, $previewDiv, previewInitial) {
}

$(function () {
$('[data-toggle="tooltip"]').tooltip();
$('[data-bs-toggle="tooltip"]').tooltip();
});

function initializeKeyboardShortcuts() {
Expand Down
10 changes: 9 additions & 1 deletion webapp/templates/jury/analysis/contest_overview.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ table tr a {
color: inherit;
}
</style>
<script>
$(function() {
$('[data-bs-toggle="popover"]').popover({
trigger: 'hover',
html: true
})
})
</script>
{% endblock %}

{% block content %}
Expand All @@ -36,7 +44,7 @@ table tr a {
Contest Stats
</div>
<div class="card-body">
<abbr data-bs-toggle="popover" data-placement="bottom" data-bs-title="Misery Index" data-bs-content="
<abbr data-bs-toggle="popover" data-bs-placement="bottom" data-bs-title="Misery Index" data-bs-content="
This is a measure of how 'bored' contestants are. It is the average number of
people-minutes spent fruitlessly trying to solve problems at the end of the contest.
<br>
Expand Down
2 changes: 1 addition & 1 deletion webapp/templates/jury/entity_id_badge.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<span class="badge text-bg-secondary id-badge" data-bs-toggle="tooltip" data-placement="top" title="{% if label is defined and label | length %}Label: {{ label }}, {% endif %}{% if externalId is not null %}External ID: {{ externalId }}, {% endif %}Internal ID: {{ idPrefix }}{{ id }}">
<span class="badge text-bg-secondary id-badge" data-bs-toggle="tooltip" data-bs-placement="top" title="{% if label is defined and label | length %}Label: {{ label }}, {% endif %}{% if externalId is not null %}External ID: {{ externalId }}, {% endif %}Internal ID: {{ idPrefix }}{{ id }}">
{% if label is defined and label | length %}
{{ label }}
{% elseif externalId is not null %}
Expand Down
6 changes: 3 additions & 3 deletions webapp/templates/partials/problem_list.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@
<div
class="problem-stats-item {{ itemClass }}"
data-bs-toggle="tooltip"
data-placement="top"
data-html="true"
title="Between {{ stat.start.timestamp | printtime(null, contest) }} and {{ stat.end.timestamp | printtime(null, contest) }}:{{ '\n' }}{{ label }}">
data-bs-placement="top"
data-bs-html="true"
title="Between {{ stat.start.timestamp | printtime(null, contest) }} and {{ stat.end.timestamp | printtime(null, contest) }}:<br/>{{ label }}">
</div>
{% endfor %}
</div>
Expand Down
Loading