Fix importing a problem archive failed alert with "Array Array Array" #2639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowadays, the messages is a keyed array with the keys being the warning level. Previously, it was a flat data structure and apparently we didn't clean up all of them. There is still a code duplication between the two controller, but moving this to the Utils class is ugly because it would require passing in the controller. Fixes DOMjudge#2633. (cherry picked from commit a6640d5)
|
Failing test is the integration, that is to be expected. You should probably pick the version from main as GitLab doesn't use CGroupV1 anymore. |
|
It seems that the CI failed to validate json schema. I'm trying to find the reason... |
This is unfortunate but gitlab seems to have enabled cgroups v2 on their runners and we still use cgroups v1, see DOMjudge#1072 (cherry picked from commit cb9e1a7)
This way, CI doesn't just break when the upstream Contest API draft specification changes. (cherry picked from commit 53ccfef)
This fixes the CI as the commit we used to pin to before did not exist anymore. (cherry picked from commit 5a59d30)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has already been fixed since a6640d5 (and released in 8.3). Need backport to 8.2 branch.
Closes #2633.
(cherry picked from commit a6640d5)