Allow changing the multi-pass problems attributes in the web UI. #2733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cubercsl |
nickygerritsen
approved these changes
Oct 5, 2024
nickygerritsen
approved these changes
Oct 5, 2024
| 'label' => 'Multi-pass problem', | ||
| 'required' => false, | ||
| ]); | ||
| $builder->add('multipassLimit', IntegerType::class, [ |
There was a problem hiding this comment.
We could hide this with some JavaScript but I will do this later
There was a problem hiding this comment.
Do you think we should check this value before saving?
For multi-pass problems, the passlimit must be >= 2, and for traditional problem it must be equal to 1. (I noticed that getMultiPassLimit checks for traditional problem, but the value stored in the db may be inconsistent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2307.