Skip to content

Default only show activated contests in the contests API #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Default only show activated contests in the contests API #2799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions webapp/src/Controller/API/ContestController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public function addContestAction(Request $request): string
name: 'onlyActive',
description: 'Whether to only return data pertaining to contests that are active',
in: 'query',
schema: new OA\Schema(type: 'boolean', default: false)
schema: new OA\Schema(type: 'boolean', default: true)
)]
public function listAction(Request $request): Response
{
Expand Down Expand Up @@ -953,7 +953,7 @@ public function samplesDataZipAction(Request $request): Response
protected function getQueryBuilder(Request $request): QueryBuilder
{
try {
return $this->getContestQueryBuilder($request->query->getBoolean('onlyActive', false));
return $this->getContestQueryBuilder($request->query->getBoolean('onlyActive', true));
} catch (TypeError) {
throw new BadRequestHttpException('\'onlyActive\' must be a boolean.');
}
Expand Down
Loading