Python code style and typing #2822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix all typing errors and style warnings reported by the `pycodestyle` tool. The max line length is not PEP 8, but limited to 120 characters. As working with mixed types such as `list | None` is annoying, the return value of `None` has been replaced with the empty lists and dictionaries for most functions, as this results in behavioural equivalent Python code in our case.
Kevinjil
force-pushed
the
python-typing
branch
from
83066d7 to
c7fb838
Compare
eldering
reviewed
Nov 22, 2024
Kevinjil
force-pushed
the
python-typing
branch
2 times, most recently
from
f5ed04a to
224c540
Compare
Kevinjil
force-pushed
the
python-typing
branch
from
224c540 to
2fb4986
Compare
Kevinjil
force-pushed
the
python-typing
branch
from
7675afb to
d5f3e8b
Compare
eldering
reviewed
Nov 22, 2024
| parsed = urlparse(domjudge_webapp_folder_or_api_url) | ||
| auth = None | ||
| if parsed.username or parsed.password: | ||
| if parsed.username and parsed.password: |
There was a problem hiding this comment.
This looks like an actual bugfix, could you put that in a separate commit?
The HTTP Basic Auth requires both a username and password. The typing in the requests library does so as well.
Kevinjil
force-pushed
the
python-typing
branch
from
d5f3e8b to
5aac0d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.