Skip to content

Conversation

nickygerritsen
Copy link
Member

Fixes #2762.

Comment on lines +374 to +376
if (scoretn && scoretn.classList.contains('cl_FFFFFF')) {
scoretn.classList.remove('cl_FFFFFF');
scoretn.classList.add('cl_FFFFE0');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I guess that's one way to fix the white colour 😂

Is the extra cl_FFFFE0 class needed, when the wrapping <div> will receive the background colour lightyellow anyway? 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that cl_ thing is there because if you set a fixed team column width, we do a 'fade out'. For that to work we need an actual background colour always. So I'm just switching it out. Not the most beautiful but it works.

{% set previousSortOrder = -1 %}
{% set previousTeam = null %}
{% set backgroundColors = {"#FFFFFF": 1} %}
{% set backgroundColors = {"#FFFFFF": 1, '#FFFFE0': 1} %}
Copy link
Contributor

@mpsijm mpsijm Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for? Is it still needed after resolving the previous comment? (also on line 359)

EDIT: oh, never mind 😄 Still curious what it's for, though 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think we don't have to do the loop twice though. let me fix that

@nickygerritsen nickygerritsen added this pull request to the merge queue Nov 22, 2024
Merged via the queue into DOMjudge:main with commit a53c481 Nov 22, 2024
30 checks passed
@nickygerritsen nickygerritsen deleted the mobilehearts branch November 22, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to favorite / heart teams in the mobile view

3 participants