Warn jury if clarification is claimed concurrently #2840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
approved these changes
Nov 23, 2024
When the form is rendered, the current jury member assigned to a clarification is stored in a hidden input field. If, during the validation, the currently assigned jury member has changed and is not the current user, warn the jury member and force a resubmission to confirm. Alternative implementation of #2766
Kevinjil
force-pushed
the
clarification-claim
branch
from
e284359 to
2c6510b
Compare
meisterT
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation of #2766 which performs the validation in the same request as the form submission by using a Symphony form callback.
fixes #2481
closes #2766