Respond in JSON for URL's below API if 404 #2841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
force-pushed
the
api-respond-in-json
branch
from
8a651f6 to
582caef
Compare
Kevinjil
approved these changes
Nov 23, 2024
vmcj
reviewed
Nov 24, 2024
| $acceptHeader = $request->headers->get('accept'); | ||
|
|
||
| if (!$acceptHeader | ||
| || str_starts_with($acceptHeader, 'text/html') |
There was a problem hiding this comment.
Is this allowed by the specs? I think if someone explicit requests text/html only we should still return text/html.
Can we do the alternative of when the acceptHeader contains app/json or is */* set it to app/json only?
There was a problem hiding this comment.
To me it's annoying if you open a wrong api in your browser you don't get json.
Seeks an n=1 test with GitHub also returns json: https://api.github.com/bla
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2685.