Only debug log the HTML of failed API requests #2862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
approved these changes
Nov 27, 2024
vmcj
approved these changes
Nov 29, 2024
vmcj
reviewed
Nov 29, 2024
Kevinjil
force-pushed
the
submit-html
branch
from
8e0d2c5 to
34afef1
Compare
|
I propose a different solution. Always log the response text to the debug console, and only print it to the user if it was a valid JSON response. The response message in JSON format returned from the API can actually be informative for users as to why the request failed. |
Kevinjil
force-pushed
the
submit-html
branch
from
34afef1 to
703b5c9
Compare
vmcj
reviewed
Dec 14, 2024
If the response is not valid JSON, do not print it to stdout and only log it to debug output.
Kevinjil
force-pushed
the
submit-html
branch
from
703b5c9 to
991caf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2842