Move all inline style to dedicated endpoint #2877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #[Route(path: '/dynamic-css', name: 'get_dynamic_css')] | ||
| public function dynamicCSS(): Response { | ||
| $response = new Response(); | ||
| $response->headers->set('Content-Type', 'text/css'); |
There was a problem hiding this comment.
We should maybe set some expire headers? Otherwise browsers won't cache it.
Drawback is that it will change once the colors change, so maybe use an etag header instead?
There was a problem hiding this comment.
We discussed and I'll try to implement a cache and keep the etag there.
There was a problem hiding this comment.
I wonder if the current implementation is not already enough, we save on the bandwidth but still need to calculate the "whole" page (as we did before).
vmcj
force-pushed
the
webstandard_cleanup
branch
from
a0f9cd3 to
fed305a
Compare
vmcj
force-pushed
the
webstandard_cleanup
branch
2 times, most recently
from
771d0a7 to
255d7db
Compare
vmcj
force-pushed
the
webstandard_cleanup
branch
from
255d7db to
d0e3037
Compare
nickygerritsen
approved these changes
Feb 23, 2025
We rendered the <style> within the <body> which is not valid. By moving it to a dedicated endpoint we also save a bit of bandwith as this is content which stays static during the contest.
vmcj
force-pushed
the
webstandard_cleanup
branch
from
d0e3037 to
a5da764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rendered the <style> within the which is not valid. By moving it to a dedicated endpoint we also save a bit of bandwith as this is content which stays static during the contest.