Skip to content

Installation fails without a Session #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Feb 26, 2025

It fixes my problem, but I'm not sure if there is not an underlying problem.

As we create a request it makes sense we also need a session, but does that session also need other things? I don't know enough about Symfony to be sure that this is besides a solution for my problem also the correct fix for the issue where no session is set.

I hope @nickygerritsen has some ideas?

@vmcj vmcj requested a review from nickygerritsen February 26, 2025 20:16
Copy link
Member

@nickygerritsen nickygerritsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe some upgrade requires us to have a session. If this works it works I'd say

@vmcj vmcj added this pull request to the merge queue Feb 26, 2025
Merged via the queue into DOMjudge:main with commit 1692fd4 Feb 26, 2025
35 checks passed
@vmcj vmcj deleted the api_command_session branch February 26, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants