Skip to content

Replace medals legend with actual medals in the scoreboard. #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
+7 −21
Merged

Replace medals legend with actual medals in the scoreboard. #2899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions webapp/public/style_domjudge.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,9 +280,9 @@ img.affiliation-logo {
.score_incorrect { background: #e87272; }
.score_pending { background: #6666ff; }

.gold-medal { background-color: #eec710 }
.silver-medal { background-color: #aaa }
.bronze-medal { background-color: #c08e55 }
.gold-medal { color: #eec710 }
.silver-medal { color: #aaa }
.bronze-medal { color: #c08e55 }

#scoresolv,#scoretotal,#scoresolvmobile,#scoretotalmobile { width: 2.5em; }
.scorenc,.scorett,.scorepl { text-align: center; width: 2ex; }
Expand Down
22 changes: 4 additions & 18 deletions webapp/templates/partials/scoreboard_table.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,10 @@
{% endif %}
<tr class="{{ classes | join(' ') }}" data-team-id="{{ score.team.teamid }}">
{% if enable_ranking %}
<td class="scorepl {{medalColor}}">
<td class="scorepl">
{% if medalColor != '' %}
<i class="fa fa-medal {{medalColor}}" style="font-size: 1.5rem;"></i>
{% endif %}
{# Only print rank when score is different from the previous team #}
{% if not displayRank %}
?
Expand Down Expand Up @@ -562,23 +565,6 @@
</tbody>
</table>
{% endif %}
{% if medalsEnabled %}
<table class="d-none d-md-table scoreboard scorelegend {% if jury %}scoreboard_jury{% endif %}">
<thead>
<tr>
<th scope="col">Medals {% if not scoreboard.freezeData.showFinal %}(tentative){% endif %}</th>
</tr>
</thead>
<tbody>
{% for medalType in ['Gold', 'Silver', 'Bronze'] %}
<tr class="{{ medalType | lower }}-medal">
<td>{{ medalType }} Medal</td>
</tr>
{% endfor %}
</tbody>
</table>
{% endif %}
{% endif %}
<script>
Expand Down
Loading