Skip to content

Record validator metadata. #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2025
Merged

Record validator metadata. #2936

merged 1 commit into from
Mar 2, 2025

Conversation

meisterT
Copy link
Member

@meisterT meisterT commented Mar 2, 2025

This can be especially useful when the validator takes more resources than expected or is misbehaving in other ways.

Example:

image

and

image

Copy link

sentry-io bot commented Mar 2, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: webapp/src/Controller/API/JudgehostController.php

Function Unhandled Issue
App\Controller\API\JudgehostController::addJudgingRunAction Symfony\Component\HttpKernel\Exception\BadRequestHttpException: Inconsistent data, no judging run known with judgetaskid = 29718. /src/Controller/API/JudgehostContr...
Event Count: 15
📄 File: webapp/src/Controller/Jury/SubmissionController.php (Click to Expand)
Function Unhandled Issue
App\Controller\Jury\SubmissionController::viewAction Symfony\Component\HttpKernel\Exception\NotFoundHttpException: No submission found with ID 708 /src/Controller/Jury/SubmissionController.php in App\Con...
Event Count: 1
---

Did you find this useful? React with a 👍 or 👎

@meisterT
Copy link
Member Author

meisterT commented Mar 2, 2025

(Fixed the unnecessary clock in the second screenshot already)

Copy link

github-actions bot commented Mar 2, 2025

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 8534034. ± Comparison against base commit 9013f12.

♻️ This comment has been updated with latest results.

This can be especially useful when the validator takes more resources
than expected or is misbehaving in other ways.
@meisterT meisterT added this pull request to the merge queue Mar 2, 2025
Merged via the queue into DOMjudge:main with commit 71b45e4 Mar 2, 2025
37 checks passed
@meisterT meisterT deleted the valmeta branch March 2, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants