Improve source diff viewer. #2945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When viewing a submission from a team who previously submitted to the same problem, we originally displayed a short unified diff below the source. When we switched to Monaco, we did replace it view a Monaco diff editor which will display the full source (either inline or side by side). That caused us to display the source twice. Now, if there is a previous submission, we only display the diff editor. New files are still downloadable and editable.
nickygerritsen
approved these changes
Mar 2, 2025
Kevinjil
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing a submission from a team who previously submitted to the same problem, we originally displayed a short unified diff below the source.
When we switched to Monaco, we did replace it view a Monaco diff editor which will display the full source (either inline or side by side). That caused us to display the source twice.
Now, if there is a previous submission, we only display the diff editor. New files are still downloadable and editable.
Example: