Fix reltime to seconds parsing #2969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No behavioral changes intended: the negative modifier bug is explicitly included in this refactoring.
|
Does this still work with the non reltime format which we still will have in the current ICPC season? |
Yes: the spec change is not in this PR, only the refactoring and the bugfix. I will update my branch fix/penaltytime with the spec change ("ugly" fix) such that we can cherry-pick it for contests if we need it for as long as we don't implement the new spec properly. |
meisterT
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted the refactor and bug fix of #2946 to a separate PR. The change in the API spec is not included in this change: I will rebase the temporary fix on
mainafter merging this.In the original code, the modifier was only applied to the hours of the reltime string. Note that test
testRelTimeToSecondsWithNegativefails without the fix commit: