Skip to content

When exporting problems, keep original filename if possible. #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025
Merged

When exporting problems, keep original filename if possible. #2978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions webapp/src/Controller/Jury/ProblemController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,27 +1122,46 @@ public function addAction(Request $request): Response

/**
* @param Testcase[] $testcases
*
* Assumes testcases are in order of their rank.
*/
private function addTestcasesToZip(array $testcases, ZipArchive $zip, bool $isSample): void
{

// Verify whether order of original filenames matches order of testcases by rank.
// If so, prefer their original name, otherwise replace the name with the rank to ensure same order.
$prev = null;
$isStillSorted = true;
foreach ($testcases as $testcase) {
if ($prev !== null && $prev >= $testcase->getOrigInputFilename()) {
$isStillSorted = false;
break;
}
$prev = $testcase->getOrigInputFilename();
}

$formatString = sprintf('data/%%s/%%0%dd', ceil(log10(count($testcases) + 1)));
$rankInGroup = 0;
foreach ($testcases as $testcase) {
$rankInGroup++;
$filename = sprintf($formatString, $isSample ? 'sample' : 'secret', $rankInGroup);
$zip->addFromString($filename . '.in', $testcase->getContent()->getInput());
$zip->addFromString($filename . '.ans', $testcase->getContent()->getOutput());
if ($isStillSorted) {
$filenamePrefix = sprintf("data/%s/%s", $isSample ? 'sample' : 'secret', $testcase->getOrigInputFilename());
} else {
$filenamePrefix = sprintf($formatString, $isSample ? 'sample' : 'secret', $rankInGroup);
}
$zip->addFromString($filenamePrefix . '.in', $testcase->getContent()->getInput());
$zip->addFromString($filenamePrefix . '.ans', $testcase->getContent()->getOutput());

if (!empty($testcase->getDescription(true))) {
$description = $testcase->getDescription(true);
if (!str_contains($description, "\n")) {
$description .= "\n";
}
$zip->addFromString($filename . '.desc', $description);
$zip->addFromString($filenamePrefix . '.desc', $description);
}

if (!empty($testcase->getImageType())) {
$zip->addFromString($filename . '.' . $testcase->getImageType(),
$zip->addFromString($filenamePrefix . '.' . $testcase->getImageType(),
$testcase->getContent()->getImage());
}
}
Expand Down
Loading