Skip to content

Conversation

meisterT
Copy link
Member

Points and time have been calculated already in

$this->numPoints = $rankCache->getPointsRestricted();

There is no need to recalculate it (which would double it).

@meisterT meisterT requested a review from nickygerritsen April 24, 2025 13:16
Points and time have been calculated already in
https://github.com/DOMjudge/domjudge/blob/6613b28ba7eebfdb300222361252d2e731399c99/webapp/src/Utils/Scoreboard/TeamScore.php#L21

There is no need to recalculate it (which would double it).
@meisterT meisterT force-pushed the fixsinglescoreboard branch from ed93ac1 to 13be37d Compare April 24, 2025 18:03
@meisterT meisterT enabled auto-merge April 24, 2025 18:04
@meisterT meisterT added this pull request to the merge queue Apr 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2025
@meisterT meisterT added this pull request to the merge queue Apr 25, 2025
Merged via the queue into DOMjudge:main with commit 2ff4da6 Apr 25, 2025
36 checks passed
@meisterT meisterT deleted the fixsinglescoreboard branch April 25, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants