Skip to content

When we shadow, trust the filenames and file sizes. #3004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
Merged

When we shadow, trust the filenames and file sizes. #3004

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c9ec9f
When we shadow, trust the filenames and file sizes, but treat them as…
nickygerritsen May 25, 2025
b84d42c
Use enum for submission source
nickygerritsen Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions webapp/src/Service/SubmissionService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ public function submitSolution(

if (!empty($entryPoint) && !preg_match(self::FILENAME_REGEX, $entryPoint)) {
$message = sprintf("Entry point '%s' contains illegal characters.", $entryPoint);
if ($forceImportInvalid) {
if ($forceImportInvalid || $source === 'shadowing') {
$importError = $message;
} else {
return null;
Expand Down Expand Up @@ -610,7 +610,7 @@ public function submitSolution(
}
if (!preg_match(self::FILENAME_REGEX, $file->getClientOriginalName())) {
$message = sprintf("Illegal filename '%s'.", $file->getClientOriginalName());
if ($forceImportInvalid) {
if ($forceImportInvalid || $source === 'shadowing') {
$importError = $message;
} else {
return null;
Expand Down Expand Up @@ -647,7 +647,7 @@ public function submitSolution(

if ($totalSize > $sourceSize * 1024) {
$message = sprintf("Submission file(s) are larger than %d kB.", $sourceSize);
if ($forceImportInvalid) {
if ($forceImportInvalid || $source === 'shadowing') {
$importError = $message;
} else {
return null;
Expand Down
Loading