Repair PHPStan GHA #3012
Merged
Repair PHPStan GHA #3012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
vmcj-patch-2
branch
5 times, most recently
from
597f71e to
a861bd4
Compare
nickygerritsen
approved these changes
Jul 4, 2025
nickygerritsen
force-pushed
the
vmcj-patch-2
branch
from
a861bd4 to
7887462
Compare
In the past we would get the annotation but the pipeline stopped failing. This resulted in some PHPStan findings not being handled. We could consider removing the GH action but that would remove the annotations.
nickygerritsen
force-pushed
the
vmcj-patch-2
branch
from
7887462 to
5a5a24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't fail on PHPStan errors anymore.