Allow more absolute times in Contest validation. #3050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
approved these changes
Aug 4, 2025
This fixes the following situation: - Upload a valid contest either via UI or API. - Shadow the contest and receive a valid CLICS start_time update - In the UI we would validate the contest and consider the contest invalid. In the contest validation we only considered the DateTime format with timezones and not offsets - The UI for rejudgings is now also locked as we validate the contest on multiple pages. To make this easier to read the regex is now also extracted to separate variables. That way it was easier to verify that our relative times are escaped correctly (+ is special for regex). Also added some smaller parts: - The `+` seems optional for relative times See the CLICS spec: https://github.com/icpc/ccs-specs/blame/master/Contest_API.md#L235. - Allow also only 1 subsecond for absolute positive URLs - We now also allow: yyyy-mm-ddThh:mm:ss(.uuu)?[+-]zz(:mm)? besides (T instead of space between date & time) yyyy-mm-dd hh:mm:ss(.uuu)?[+-]zz(:mm)? See: https://github.com/icpc/ccs-specs/blame/master/Contest_API.md#L233 - Allow for the Z shorthand for UTC - Disallow different offsets in the contest times. CLICS allows for this but we can fix this if there is ever a real usecase for it. We already did this for timezones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple commits as its very easy to forget to move a single character. Did not check if the Unit tests pass yet.
We need this for the practice which we're shadowing. PC2 gives an start_time which is not valid according to us but is according to the CLICS spec.
When approved we can squash this to a single commit.