Skip to content

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Aug 10, 2025

Mostly as PoC,

I think this is helpful for the current state where interactive problems have overhead.

If we want to do this:

  • I think lib.misc.php can mostly be moved to utils for this
  • I made some things static, I assume this is an improvement but I'm not 100% on the performance gain/impact

@vmcj vmcj force-pushed the interactive_extra_time branch 7 times, most recently from 6f91416 to 594135a Compare August 10, 2025 15:35
vmcj added 2 commits August 10, 2025 17:43
Currently interactive problems need more time due to the pipeline
handling. Other problemtypes shouldn't have such requirements but if
someone has a slower interactor or compare script for some types this
can be helpful.

So we both do this to not have `interactive` as special case and to
provide people with the option due to unforseen setups.
@vmcj vmcj force-pushed the interactive_extra_time branch from 594135a to b668e96 Compare August 10, 2025 15:43
Copy link
Member

@eldering eldering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it best to first discuss how we best address this issue with the interactive validator sometimes requiring a lot of extra wallclock time. Ideally we solve that or just add wallclock extra overhead for interactive problems, not generic (also CPU time) overhead.

A side note: there are some problem color changes in this PR.

description: Maximum filesize (in kB) compile/compare scripts may write. Submission will fail with compiler-error when trying to write more, so this should be greater than any **intermediate or final** result written by compilers.
regex: /^[1-9]\d*$/
error_message: A positive number is required.
- name: timelimit_overshoot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this separate from timelimit_overshoot. Let's discuss in person?

@vmcj vmcj closed this Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants