Autocheck for new DOMjudge releases #3055

vmcj · 2025-08-23T11:11:05Z

Discussed during the NWERC hackathon in 2023.

We allow admins to toggle an autoquery to domjudge.org for 2 reasons:

Alerting users that a new version might exist, helping us in case of security releases.
Giving a gentle nudge for people to upgrade making support easier.
Getting some information on what installations are out there.

Default this doesn't happen, so the admin chooses to enable this themselves so this is different from normal telemetry.

Discussed during the hackathon in 2023. We allow admins to toggle an autoquery to domjudge.org for 2 reasons: - Alerting users that a new version might exist, helping us in case of security releases. - Giving a gentle nudge for people to upgrade making support easier. - Getting some information on what installations are out there.

nickygerritsen · 2025-08-23T12:25:55Z

webapp/src/Service/DOMJudgeService.php

+            return false;
+	}
+        $versionLocalString = explode("/", str_replace("DEV", "-prerelease", $this->domjudgeVersion))[0];
+        $versionLocal = Version::parse($versionLocalString, false);


Why tarball in the user agent and not DOMjudge like we do when shadowing?

We also wanted to know which installmethods are out there, so next step is a config variable but I had no idea on how to set that (yet) I suspect a make option..

nickygerritsen · 2025-08-23T12:28:15Z

webapp/src/Service/DOMJudgeService.php

+         * the user can see on the website if there is a new Major/minor themselves
+         * otherwise the latest minor, or Major release. So the user might make the upgrade path:
+         * DJ6.0.0 -> DJ6.0.6 -> DJ6.6.0 -> DJ9.0.0 instead of
+         *         -> DJ6.0.[1..6] -> DJ6.[1..6] -> DJ[7..9].0.0


This whole loop could also be done by sorting the versions lexicographically and taking the next one higher than the local version. This could replace all three checks?

Wouldn't that give the path over all patches, minor plus patches in that minor etc?

Basically the 2nd path I mentioned.

Ah yeah you might be right but we could solve that by only exposing specific versions on the versions site?

Even if the array would only the latest patch release per M.m release we would still need to filter somewhere.

But I get the point that we should do something smarter so the code is less duplicated.

We still need the loop as at best we can only clean the list to always have the highest patch version in the list,

We could ofcourse do this math on the version site and basically only let the server do a lookup there so:
{'1.1.5': '1.5.5',
'1.2.3': '1.2.5',
'1.5.5': '5.5.5'}
where 5 is always the highest version in that release.

But that also feels expensive, it just removes the calculation to another server.

I did some cleanup though and I think this is already more what you want. Although I'm not 100% if it will now not also alert for the current version.

Should we not return just the newest version here?

meisterT · 2025-08-31T08:13:47Z

etc/db-config.yaml

+            type: bool
+            default_value: false
+            public: false
+            description: Automatically check for new DOMjudge release?


Suggested change

description: Automatically check for new DOMjudge release?

description: Automatically check and notify for new DOMjudge releases?

meisterT · 2025-08-31T08:14:21Z

webapp/src/Service/DOMJudgeService.php

@@ -1671,4 +1674,42 @@ public function getAllowedLanguagesForContest(?Contest $contest) : array {
            ->getQuery()
            ->getResult();
    }
+
+    public function checkNewVersion(): string|false {
+        if (!$this->config->get('check_new_version')) {


Suggested change

if (!$this->config->get('check_new_version')) {

if (!$this->config->get('check_new_version', false)) {

meisterT · 2025-08-31T08:18:05Z

webapp/src/Service/DOMJudgeService.php

+    public function checkNewVersion(): string|false {
+        if (!$this->config->get('check_new_version')) {
+            return false;
+        }


Nit: add a comment here like, that will make understanding the code easier:

// Version is something like "x.y.z / commit hash", e.g. "6.1.2 / 4e25adb13"

meisterT · 2025-08-31T08:19:15Z

webapp/src/Service/DOMJudgeService.php

+            return false;
+        }
+        $versionLocalString = explode("/", $this->domjudgeVersion)[0];
+        $patch = "/" . substr($this->domjudgeVersion, 0, strrpos($this->domjudgeVersion, '.')) . ".\d/";


replace these with explode on .?

Also verify that there are three elements and silently return false if not

meisterT · 2025-08-31T08:21:16Z

webapp/src/Service/DOMJudgeService.php

@@ -1671,4 +1674,42 @@ public function getAllowedLanguagesForContest(?Contest $contest) : array {
            ->getQuery()
            ->getResult();
    }
+
+    public function checkNewVersion(): string|false {


nit: add a comment what this function should return

meisterT · 2025-08-31T08:23:58Z

webapp/src/Service/DOMJudgeService.php

+        if ($response === false) {
+            return false;
+        }
+        $versions = json_decode($response, true);


nit: add a comment to explain what format you expect the server to return

meisterT · 2025-08-31T08:25:48Z

webapp/src/Service/DOMJudgeService.php

+         * the user can see on the website if there is a new Major/minor themselves
+         * otherwise the latest minor, or Major release. So the user might make the upgrade path:
+         * DJ6.0.0 -> DJ6.0.6 -> DJ6.6.0 -> DJ9.0.0 instead of
+         *         -> DJ6.0.[1..6] -> DJ6.[1..6] -> DJ[7..9].0.0


Should we not return just the newest version here?

meisterT · 2025-08-31T08:26:09Z

webapp/templates/jury/menu.html.twig

+        {% if new_version_available %}
+            <ul class="navbar-nav">
+                <li class="nav-item nav-link">
+                    <i class="fa-solid fa-ship fa-2x"></i> New release {{ new_version_available }} available.


To do that I need to make it unraw, I'll need @nickygerritsen for that if we want this.

vmcj force-pushed the check_version branch from 0353d97 to 18e58bb Compare August 23, 2025 11:15

vmcj force-pushed the check_version branch from 18e58bb to 378db01 Compare August 23, 2025 11:25

nickygerritsen reviewed Aug 23, 2025

View reviewed changes

vmcj force-pushed the check_version branch from 0b9677d to f2a225c Compare August 24, 2025 10:42

Remove duplication

de80c58

vmcj force-pushed the check_version branch from f2a225c to de80c58 Compare August 25, 2025 08:56

meisterT reviewed Aug 31, 2025

View reviewed changes

	description: Automatically check for new DOMjudge release?
	description: Automatically check and notify for new DOMjudge releases?

	if (!$this->config->get('check_new_version')) {
	if (!$this->config->get('check_new_version', false)) {

Autocheck for new DOMjudge releases #3055

Are you sure you want to change the base?

Autocheck for new DOMjudge releases #3055

Conversation

vmcj commented Aug 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vmcj Aug 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickygerritsen Aug 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vmcj Aug 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vmcj Aug 23, 2025 •

edited

Loading

nickygerritsen Aug 23, 2025 •

edited

Loading

vmcj Aug 24, 2025 •

edited

Loading