Skip to content

Clean up mentions of external ID on submission page. #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2025
Merged

Clean up mentions of external ID on submission page. #3077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 19 additions & 30 deletions webapp/templates/jury/submission.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,15 +197,20 @@
</a>
</span>

{% if external_ccs_submission_url is not empty %}
{% set externalSubmissionUrl = submission | externalCcsUrl %}
{% if externalSubmissionUrl is not empty %}
<span>
<i class="fas fa-link" title="External link:"></i>
<a href="{{ externalSubmissionUrl }}" target="_blank">
View in external CCS
</a>
</span>
{% if shadowMode() and submission.externalid %}
{% if external_ccs_submission_url is empty %}
External ID: {{- submission.externalid -}}
{% else %}
{% set externalSubmissionUrl = submission | externalCcsUrl %}
{% if externalSubmissionUrl is not empty %}
<span>
<i class="fas fa-link" title="External link:"></i>
<a href="{{ externalSubmissionUrl }}" target="_blank">
View in external CCS
</a>
(ID: {{- submission.externalid -}})
</span>
{% endif %}
{% endif %}
{% endif %}
</div>
Expand All @@ -230,22 +235,6 @@
</div>
{% endif %}

{% if shadowMode() and submission.externalid %}
<div class="mb-2">
External ID:
{% if external_ccs_submission_url is empty %}
{{- submission.externalid -}}
{% else %}
<a href="{{ submission | externalCcsUrl }}" target="_blank">
{{- submission.externalid -}}
</a>
{%- endif -%}
{%- if externalJudgement is not null -%}
, {{ externalJudgement.result | printValidJuryResult }}
{% endif %}
</div>
{% endif %}

{% if externalJudgement is not null and externalJudgement.result is not empty and (
(selectedJudging is not null and selectedJudging.result is not empty and externalJudgement.result != selectedJudging.result)
or submission.importError) %}
Expand Down Expand Up @@ -558,11 +547,11 @@
</td>
<td>
{% if externalSubmissionUrl is defined and externalSubmissionUrl is not empty %}
<a href="{{ externalSubmissionUrl }}">
{% endif %}
external {{ externalJudgement.extjudgementid }}
{% if externalSubmissionUrl is defined and externalSubmissionUrl is not empty %}
</a>
<a href="{{ externalSubmissionUrl }}">
{% endif %}
external
{% if externalSubmissionUrl is defined and externalSubmissionUrl is not empty %}
</a>
{% endif %}
</td>
</tr>
Expand Down
Loading