Add clarifications to the team problemset page. #3087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
added a commit
to meisterT/domjudge
that referenced
this pull request
Sep 6, 2025
Previously, the following could happen: - team A requests a clarification, potentially including details the jury doesn't want to broadcast - the jury replies to everyone, removing the part from the question that they don't want to have broadcasted - team B views the reply from the jury, sees the whole clarification thread Found while working on DOMjudge#3087
meisterT
force-pushed
the
clars_probset
branch
from
2cee86f to
b8c3596
Compare
|
Im not 100% sure if I like this better than what I suggested in the issue. This feels out of place to me. |
meisterT
added a commit
to meisterT/domjudge
that referenced
this pull request
Sep 7, 2025
Previously, the following could happen: - team A requests a clarification, potentially including details the jury doesn't want to broadcast - the jury replies to everyone, removing the part from the question that they don't want to have broadcasted - team B views the reply from the jury, sees the whole clarification thread Found while working on DOMjudge#3087
|
How do like something like this then? 
|
Yes but I was clearly wrong with the greyed out button. It doesn't add anything and just takes up space. |
meisterT
force-pushed
the
clars_probset
branch
from
b8c3596 to
8e80286
Compare
|
Alright, changed my commit to that effect. Please take a look. |
|
(I need to fix the unit test, will do that after we agreed whether this is the right approach) |
|
I assume So LGTM after fixing the unit tests. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2025
Previously, the following could happen: - team A requests a clarification, potentially including details the jury doesn't want to broadcast - the jury replies to everyone, removing the part from the question that they don't want to have broadcasted - team B views the reply from the jury, sees the whole clarification thread Found while working on #3087
meisterT
force-pushed
the
clars_probset
branch
from
8e80286 to
f6be67a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3009
Example:
Clicking on one opens the regular clarification modal dialog: