Skip to content

Properly restrict clarification thread to team. #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
Merged

Properly restrict clarification thread to team. #3088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions webapp/src/Controller/Team/ClarificationController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,12 @@ public function viewAction(Request $request, int $clarId): Response
throw new HttpException(401, 'Permission denied');
}

// Get the "parent" message if we have one.
// Get the "parent" message if we have one - if we have access to it
if ($clarification->getInReplyTo()) {
$clarification = $clarification->getInReplyTo();
$parent = $clarification->getInReplyTo();
if ($team->canViewClarification($parent)) {
$clarification = $parent;
}
}

// Mark clarification as read.
Expand Down
Loading