Change diff mode selection to radio button #3095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visually, this is more in line with the rest of the design. It also clears some vertical space which can be used by the monaco editor.
meisterT
approved these changes
Sep 12, 2025
nickygerritsen
approved these changes
Sep 13, 2025
|
Not sure how easy it would be, but would be nice to have a third option "diff off" to just show the plain source. And even better would be to store this in a cookie, I think. But feel free to let either be for another PR. |
Sometimes, you want to easily read the submission instead of the diff with the previous submission. Unfortunately, Monaco cannot easily switch between a diff editor and a normal editor (see microsoft/monaco-editor#1881). We mimic the normal editor behaviour instead. Store the current diff mode instead of the side-by-side boolean in local storage. The latest release did not yet include the storage variable, so no migration is added.
|
@eldering The mode was already stored in local storage. I think it makes sense to keep it there and not move it to cookies, as there is no need to communicate it to the webserver. |
|
LGTM, 🚢 it |
eldering
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visually, this is more in line with the rest of the design. It also clears some vertical space which can be used by the monaco editor.
Old:
New:
