Skip to content

#2307 Multi-pass: copy feedback dir between passes (but remove nextpass.in) #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

#2307 Multi-pass: copy feedback dir between passes (but remove nextpass.in) #3111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions judge/judgedaemon.main.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1451,6 +1451,16 @@ function judge(array $judgeTask): bool
$passdir = $testcasedir . '/' . $passCnt;
mkdir($passdir, 0755, true);

// In multi-pass problems, all files in the feedback directory
// are guaranteed to persist between passes, except `nextpass.in`.
// So, we recursively copy the feedback directory for every pass
// after the first (note that $passCnt starts at 1).
if ($passCnt > 1) {
$prevPassdir = $testcasedir . '/' . ($passCnt - 1) . '/feedback';
system('cp -R ' . dj_escapeshellarg($prevPassdir) . ' ' . dj_escapeshellarg($passdir . '/'));
system('rm ' . dj_escapeshellarg($passdir . '/feedback/nextpass.in'));
}

// Copy program with all possible additional files to testcase
// dir. Use hardlinks to preserve space with big executables.
$programdir = $passdir . '/execdir';
Expand Down
6 changes: 3 additions & 3 deletions judge/testcase_run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ if [ $COMBINED_RUN_COMPARE -eq 1 ]; then
# A combined run and compare script may now already need the
# feedback directory, and perhaps access to the test answers (but
# only the original that lives outside the chroot).
mkdir feedback
mkdir -p feedback
RUNARGS="$RUNARGS $TESTOUT compare.meta feedback"
fi

Expand Down Expand Up @@ -234,8 +234,8 @@ if [ $COMBINED_RUN_COMPARE -eq 0 ]; then

exitcode=0
# Create dir for feedback files and make it writable for $RUNUSER
mkdir feedback
chmod a+w feedback
mkdir -p feedback
chmod -R a+w feedback

runcheck $GAINROOT "$RUNGUARD" ${DEBUG:+-v} $CPUSET_OPT -u "$RUNUSER" -g "$RUNGROUP" \
-m $SCRIPTMEMLIMIT -t $SCRIPTTIMELIMIT --no-core \
Expand Down
Loading