Fix incorrect link generation for testcase audit logs

[zapotocnylubos]

The stored ID in the audit log is the problem ID, not a testcase ID

So searching for a testcase by a problem ID results in an incorrect link to a completely different problem.

Storing the problematic audit log happens here

domjudge/webapp/src/Controller/Jury/ProblemController.php

Line 634 in af92629

$this->dj->auditlog('testcase', $probId, 'updated',

I also saw a generic audit log mechanism in BaseController

domjudge/webapp/src/Controller/BaseController.php

Line 154 in af92629

$this->dj->auditlog($auditLogType, $id, $isNewEntity ? 'added' : 'updated');

I am wondering if this is a correct-intended behavior. On one side, I see performance/logical reasons why to store only the problem ID, but keeping consistency in mind, it would also seem logical to store the testcase ID and look up the problem ID as it was originally coded.

Should we change the

$this->dj->auditlog('testcase', $probId

in all 3 locations to pass a testcase ID instead? Or use the change in the link generation I provided in this MR?

• domjudge/webapp/src/Controller/Jury/ProblemController.php

  Line 634 in af92629

  $this->dj->auditlog('testcase', $probId, 'updated',

• domjudge/webapp/src/Controller/Jury/ProblemController.php

  Line 736 in af92629

  $this->dj->auditlog('testcase', $probId, 'added', sprintf("rank %d", $maxrank));

• domjudge/webapp/src/Controller/Jury/ProblemController.php

  Line 863 in af92629

  $this->dj->auditlog('testcase', $probId, 'switch rank',

[vmcj]

I am wondering if this is a correct-intended behavior. On one side, I see performance/logical reasons why to store only the problem ID, but keeping consistency in mind, it would also seem logical to store the testcase ID and look up the problem ID as it was originally coded.

Are you willing to do some testing for this? I think the call shouldn't be that heavy so sounds reasonable to log all relevant information.

[zapotocnylubos]

Sure, I can try to do some load testing and measure it.
The main problem is that it's now inconsistent.
The controller stores the problem ID, and the auditlog table uses that problem ID as it is a testcase ID (which it is not).
Only one way should be chosen.

1. Store the testcase ID and the lookup problem ID when rendering the link
2. Store problem ID, don't do a lookup (in this MR)

[meisterT]

Since we link to the problem (or all of its testcases) anyway (and the text mentions the test case ID, so all info is there), I think the PR is the right thing to do.