Store failing page for Crawler test #3121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the E2E/Crawler is very generic it's hard to pinpoint what page is failing and why. We stored the failing page(s) with GitLab CI but this was lost after the migration.
Kevinjil
approved these changes
Sep 25, 2025
| if (getenv('CI')) { // We're running in GHA. | ||
| $ciArtifacts = getenv('ARTIFACTS'); | ||
| if ($ciArtifacts != '') { | ||
| $fileHandler = fopen(sprintf("%s/%s", $ciArtifacts, str_replace('/', '_s_', $url)), 'w'); |
There was a problem hiding this comment.
I'm not sure if this is a perfect sanitizer, but at first glance it sounds safe?
There was a problem hiding this comment.
It worked for years and it's only for debugging in CI. In case it breaks we can easily fix it with the new insights.
meisterT
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the E2E/Crawler is very generic it's hard to pinpoint what page is failing and why. We stored the failing page(s) with GitLab CI but this was lost after the migration.