Only show diff between submissions in the same contest #3125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get this case for jury imports where the same team DOMjudge uploads in multiple contests (dress + finals) and the first "finals" submission would show a diff with the last jury submission of the dress contest. We could also have this if a team is in 2 contests at the same time but although in theory possible this shouldn't happen in practice.
nickygerritsen
approved these changes
Sep 28, 2025
Huh, did you test with the same problem in both contests? |
In my test db I have the same problem in multiple contests yes. Which makes this even more of an edge case. |
|
It's a good change anyway, just wanted to understand what caused this |
meisterT
approved these changes
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get this case for jury imports where the same team DOMjudge uploads in multiple contests (dress + finals) and the first "finals" submission would show a diff with the last jury submission of the dress contest.
We could also have this if a team is in 2 contests at the same time but although in theory possible this shouldn't happen in practice.