Add multi-delete option for problems. #3133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a screenshot of how it looks? |
|
If we do this for more entities we should probably generalise it a bit |
|
Happy to generalize once we decided this is roughly how we want multi-delete to work. (I would also merge this first, and then generalize.) |
|
Here is a potential generalization demonstrated for the user entity: 749efc9 |
|
Looks good |
eldering
reviewed
Oct 4, 2025
| {% else %} | ||
| <p>You're about to delete {{ type }} {{ primaryKey }} "{{ description }}".</p> | ||
| {% if count > 1 %} | ||
| <p>You're about to delete the following {{ count }} {{ type }}s:</p> |
There was a problem hiding this comment.
Nitpick: the plural doesn't work for "category", not sure that's important enough to fix.
There was a problem hiding this comment.
indeed, I will see how to solve it when I get to team categories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #229
If this gets merged, I can extend this to other entities.