-
Notifications
You must be signed in to change notification settings - Fork 278
Clean up team index page. #3135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I like it |
I agree with removal of the I think the bolding is a clear indicator for people to check this so I don't see a reason to remove it. Removal of the |
My reasoning was:
Do you mean increase the length of the message summary? We can certainly play around with that.
What does it indicate? The bold currently only goes away after clicking on the submission. I checked at finals and out of all the teams I checked (10 or so) none clicked on their submissions to remove the bold. Why would they? The modal dialog is basically only relevant if they want to see the compiler errors or (if shown) the result to samples. In all other cases, there is no additional info given.
For me, it makes it easier to read without the gray, and also more modern, but we can just see what the majority thinks and decide based on that. |
Can we add a
That's what I meant yes. If we can make more screen space we should use it to show more clarification.
I assumed you removed the bold for clarifications? But you seem to suggest that submissions could be bold if that's the case I never used it and don't care for it so fine to remove it.
Ok, let's just do it. |
2e53b35
to
0a85aa4
Compare
What about keeping a column I also think that the striped grey was slightly clearer than without it. Maybe @thijskh can have a look too? |
Changes: - the striped tables don't provide a lot of additional value (anymore?), and I think the gray bites with table header - perhaps do the same changes later on other pages - The bold-ing of the submissions that have not been clicked is unnecessary - there is no real additional content that we want teams to acknowledge. We probably should use the unread column in the database for notifications instead - Remove the from/to columns for the clarification side and also remove the word "problem" in the subject column. from/to makes sense for jury interface but not so much for teams.
Changes:
before:

after:
