-
Notifications
You must be signed in to change notification settings - Fork 278
Add problem status to the team problem set page. #3137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels out of place in that location,
I think the score doesn't add that much extra information for correct solutions, and if we remove it we could gray out (I would pick green) the problems and have the same effect?
Instead of the score we could in the future add the new rank in case the team solves the problem.
Happy to try out other locations, which ones should we try out?
You mean color the background of the card, I actually tried that first and it looked horrible with the green submit button and the green-ish boxes.
I don't like it so much because it requires (A) explanation to the team, and (B) is largely independent of the problem to solve (modulo penalty time). |
I find the green background with the other greens in the box quite ugly :-) I can see how easy it is to align things |
@Kevinjil one way to solve the alignment problem would be moving the problem badge to the left: What are everyone's thoughts on the options? |
I don't like it so much: this way the problem badge seems less pronounced and more easily confused with a green/red (un)solved badge. And I think the problem badges should be the most obvious discernable thing here. |
I didn't check how it looked but the reason a team visits this page after the contest start is to pick a next problem. Could we split the page in 2? I suspect that the new badge is less out of place in that case (for me). |
I think people also use the page to download samples or testing tools, if you don't provide them. I'm not entirely sure if not having the problems in contest order is the way to go. If people indeed visit this page mainly to pick the next problem, then we should sort them by number of correct attempts by other teams. I'm not suggesting we do that though. |
What I propose is contest order, I just propose to do it twice. In case you re-visit the page you would want to see the problem's you haven't solved yet. Another sorting option with sorted by Solved/Tried or even #solved would be an option but what I'm suggesting is to move stuff out of view which is most likely not relevant anymore (similar for disabled languages, non-activated contests etc.). |
I do really wonder if that fixes the issue with it not looking good with Tobi's addition though. And it will move stuff around still, even though it's in order. But I might be wrong and maybe that is exactly what people want. |
I think it is worth a try. There is also another option that came to mind: gray out the whole card if a problem has been solved. Do not add any indication to the attempted problems. I will try out both and add screenshots. And then we should probably ask in Slack or so to vote for options :-) |
A side comment: I'd try changing to the color of the submit button from green to something a bit less outstanding: I think the color green creates a "conflict" with the green solved badge. |
And what do the two rows of boxes actually mean? The fact that I don't know makes me wonder if we could remove those and declutter the page a bit. |
I think the boxes are super useful and if you hover over them once you understand the concept. We should document them in the team manual though.
I think that's worse than dropping them. We should be careful with adding options, especially to the team interface. |
Example:
