Add multi-delete for users. #3138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
force-pushed
the
user_multidelete
branch
from
8e14910 to
5294e6b
Compare
Also generalize multi-delete code where it makes sense. More progress towards DOMjudge#229.
meisterT
force-pushed
the
user_multidelete
branch
from
5294e6b to
f393dea
Compare
|
Now also including teams, team affiliation, and team categories. |
Also handle plural correctly of entities ending with "y". Part of DOMjudge#229.
meisterT
force-pushed
the
user_multidelete
branch
from
d9336b6 to
dcf6d9b
Compare
meisterT
commented
Oct 4, 2025
| {% block title %} | ||
| {% if count > 1 %} | ||
| Delete {{ count }} {{ type }}s | ||
| Delete {{ count }} {% if type|slice(-1) == 'y' %}{{ type|slice(0, -1) }}ies{% else %}{{ type }}s{% endif %} |
There was a problem hiding this comment.
@eldering this is the fix for pluralizing team category
nickygerritsen
approved these changes
Oct 4, 2025
| 'name' => ['title' => 'name', 'sort' => true, 'default_sort' => true], | ||
| ]; | ||
|
|
||
| if ($this->isGranted('ROLE_ADMIN')) { |
There was a problem hiding this comment.
Should we maybe make a generalized method of this in the base class? Also for the one below? So that we don't have this repeated html everywhere, if we ever want to change styling or something.
There was a problem hiding this comment.
Done, please check the last two commits.
meisterT
force-pushed
the
user_multidelete
branch
from
6c2517d to
1183e9f
Compare
vmcj
reviewed
Oct 4, 2025
|
I think we should add unit tests for this, |
Do we have good examples for unit tests where individual entities get deleted? |
meisterT
force-pushed
the
user_multidelete
branch
from
ac7c09e to
97acf0a
Compare
|
@vmcj I have added a unit test for the problems entity in the last commit, PTAL. |
vmcj
reviewed
Oct 5, 2025
meisterT
force-pushed
the
user_multidelete
branch
from
97acf0a to
e3cf6a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also generalize multi-delete code where it makes sense.
More progress towards #229.