-
Notifications
You must be signed in to change notification settings - Fork 278
Remove support for cgroup v1. #3141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| fi # cgroup V1 | ||
| else | ||
| cgroup_error_and_usage "Error: Cgroups not configured properly, did not find cgroup v2 in /sys/fs/cgroup but '$fs_type'." | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message about cgroup v1 on line 29 should also be removed.
Is there maybe also documentation referring to cgroup v1/2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, also good call on the documentation, fixed that as well
All relevant environments (Debian, Ubuntu, RedHat, ArchLinux, WSL2, Fedora) support and default to cgroup v2 since years, and it helps with simplification of runguard, which is a precursor of merging runpipe and runguard.
I actually have to (overdue) upgrade to latest Debian release from 2 months ago to have a supported (default) kernel, so "years" is not quite true. |
|
I took this from https://wiki.debian.org/LXC/CGroupV2 where it reads "Starting with Linux kernel 4.5 (Debian Bullseye or later), cgroups v2 is now the default." |
Yeah, but we require kernel >= 5.19 to "record peak RAM usage with cgroup V2". OTOH, I noticed I was running an old kernel, so on Debian Bookworm (oldstable), 6.1.0 was actually the default kernel, so actually since 2 years our setup was fully supported on Debian :-) |
All relevant environments (Debian, Ubuntu, RedHat, ArchLinux, WSL2, Fedora) support and default to cgroup v2 since years, and it helps with simplification of runguard, which is a precursor of merging runpipe and runguard.