Skip to content

Conversation

meisterT
Copy link
Member

@meisterT meisterT commented Oct 5, 2025

All relevant environments (Debian, Ubuntu, RedHat, ArchLinux, WSL2, Fedora) support and default to cgroup v2 since years, and it helps with simplification of runguard, which is a precursor of merging runpipe and runguard.

fi # cgroup V1
else
cgroup_error_and_usage "Error: Cgroups not configured properly, did not find cgroup v2 in /sys/fs/cgroup but '$fs_type'."
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message about cgroup v1 on line 29 should also be removed.

Is there maybe also documentation referring to cgroup v1/2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, also good call on the documentation, fixed that as well

All relevant environments (Debian, Ubuntu, RedHat, ArchLinux, WSL2,
Fedora) support and default to cgroup v2 since years, and it helps with
simplification of runguard, which is a precursor of merging runpipe and
runguard.
@eldering
Copy link
Member

eldering commented Oct 5, 2025

All relevant environments (Debian, Ubuntu, RedHat, ArchLinux, WSL2, Fedora) support and default to cgroup v2 since years, and it helps with simplification of runguard, which is a precursor of merging runpipe and runguard.

I actually have to (overdue) upgrade to latest Debian release from 2 months ago to have a supported (default) kernel, so "years" is not quite true.

@meisterT
Copy link
Member Author

meisterT commented Oct 5, 2025

I took this from https://wiki.debian.org/LXC/CGroupV2 where it reads "Starting with Linux kernel 4.5 (Debian Bullseye or later), cgroups v2 is now the default."

@meisterT meisterT added this pull request to the merge queue Oct 5, 2025
@eldering
Copy link
Member

eldering commented Oct 5, 2025

I took this from https://wiki.debian.org/LXC/CGroupV2 where it reads "Starting with Linux kernel 4.5 (Debian Bullseye or later), cgroups v2 is now the default."

Yeah, but we require kernel >= 5.19 to "record peak RAM usage with cgroup V2". OTOH, I noticed I was running an old kernel, so on Debian Bookworm (oldstable), 6.1.0 was actually the default kernel, so actually since 2 years our setup was fully supported on Debian :-)

Merged via the queue into DOMjudge:main with commit d2e8b6e Oct 5, 2025
36 checks passed
@meisterT meisterT deleted the nomorecgv1 branch October 5, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants