Improve judge daemon code health and readability #3202
+1,491
−1,390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional changes intended. The new style is one step on the way to improve code health and getting this into a easier to modify state, finally opening the door to migrate to a different language.
No functional changes intended.
Member
|
I find this very hard to review, I think I like the general idea but can't really check where the lines moved to. |
Member
Author
Yes, as often with bigger refactorings, the GitHub review UI is meh. My recommendation is to check things out locally and review commit by commit by opening the old and new version of the file side by side, e.g. in vim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.