Dynamically stretch the code editor height using flexboxes #3206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using CSS flexboxes, we can stretch the document body to the full height. For doing so, we will need to use a flexbox layout from some element of which we know the desired minimal height up to the element in the DOM tree which should stretch. We achieve the stretching by defining the minimum height of the body to be 100 viewport height units and adding the `flex-pass` class to all elements in between. The `flex-pass` class sets the display method of the element to be a flexbox to allow stretching of the children, and sets its own grow and shrink to 1. To counter some rounding error encountered in Gecko and derived (firefox) browsers, we subtract 1 pixel from the full viewport height to prevent a minimal 1 pixel scrollbar.
This includes the source code and diff viewer for submissions and the executables editor for the system configuration.
Monaco allocates height on initialization, and sets this as a fixed height. By removing the height on a resize of the body, we force monaco to recompute the value and claim all newly available space of the flexbox layout. Note that we use a resize observer instead of a `$(window).resize`, as this will also trigger for other DOM changes and not just viewport changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #3198 which relies on flexbox layouts instead of computing the height ourselves, which makes it more generally applicable and probably prevents dozens of edge-cases and accessibility problems. The commit messages contain the rationale.