Fold testcase_run.sh logic into judgedaemon.
#3286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
No need to review yet, I am still testing and there are some follow-up changes required. |
meisterT
force-pushed
the
judgedaemon_go_brrrrrrrrrrrr
branch
6 times, most recently
from
d56ace2 to
afc9366
Compare
meisterT
force-pushed
the
judgedaemon_go_brrrrrrrrrrrr
branch
from
d196423 to
801bce8
Compare
meisterT
force-pushed
the
judgedaemon_go_brrrrrrrrrrrr
branch
from
801bce8 to
11e2bf7
Compare
meisterT
force-pushed
the
judgedaemon_go_brrrrrrrrrrrr
branch
from
11e2bf7 to
2e87efc
Compare
vmcj
reviewed
Jan 8, 2026
Member
vmcj
left a comment
vmcj
left a comment
There was a problem hiding this comment.
I still need to take a look at testcaseRunInternal()
example_problems/hello/submissions/time_limit_exceeded/stress-test-fork-setsid.c
Show resolved
Hide resolved
meisterT
force-pushed
the
judgedaemon_go_brrrrrrrrrrrr
branch
2 times, most recently
from
991ddde to
f19cf24
Compare
meisterT
commented
Jan 10, 2026
Member
Author
meisterT
left a comment
meisterT
left a comment
There was a problem hiding this comment.
writing nothing of essence here, just to unblock the other pending comment (insert old man yells at github meme here)
meisterT
force-pushed
the
judgedaemon_go_brrrrrrrrrrrr
branch
from
34f03a2 to
04d1a1a
Compare
vmcj
reviewed
Jan 10, 2026
meisterT
force-pushed
the
judgedaemon_go_brrrrrrrrrrrr
branch
9 times, most recently
from
b6b05e7 to
7251e44
Compare
The primary motivation is to significantly reduce the per-testcase overhead of judging a submission. Historically, with fewer test cases, the separation was carrying its weight. However, with modern problems requiring many test cases or passes, the overhead from dozens of forked simple programs (`cp`, `mv`, `chmod`, `grep` etc.) within the shell script has become a major performance bottleneck. Moving them into PHP effectively replaces them with simple system calls. This change results in a substantial performance improvement: * Roughly a 50% speed-up in total judging overhead per submission * Example: A simple C++ solution to a multi-pass problem (NWERC 2025 practice) was reduced from ~70s to ~33s end-to-end.
meisterT
force-pushed
the
judgedaemon_go_brrrrrrrrrrrr
branch
from
7251e44 to
686e7c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation is to significantly reduce the per-testcase overhead of judging a submission.
Historically, with fewer test cases, the separation was carrying its weight. However, with modern problems using many test cases or multiple passes, the overhead from dozens of forked simple programs (
cp,mv,chmod,grepetc.) within the shell script has become a major performance bottleneck. Moving them into PHP effectively replaces them with simple system calls.This change results in a substantial performance improvement: