Allow QUIET=0 as temporary fix in installation scripts#3315
Open
vmcj wants to merge 1 commit intoDOMjudge:mainfrom
Open
Allow QUIET=0 as temporary fix in installation scripts#3315vmcj wants to merge 1 commit intoDOMjudge:mainfrom
vmcj wants to merge 1 commit intoDOMjudge:mainfrom
Conversation
vmcj
force-pushed
the
quiet_sh_script_fix
branch
from
5ad0828 to
73f2a88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered this when changing our update_*.sh scripts. We use
QUIET=1there, I replaced that withQUIET=0which would enter0in a couple of places where we don't really need that. The same would happen withQUIET=2which would be a strange but valid boolean.Those fixes should make it hopefully easier to read and remove this specific issue. I couldn't find a nice way to do an or to remove the duplication so we end up with some (ugly) replication of the flags.