Properly handle all arguments when falling back to plain HTTP.#3474
Open
meisterT wants to merge 1 commit intoDOMjudge:mainfrom
Open
Properly handle all arguments when falling back to plain HTTP.#3474meisterT wants to merge 1 commit intoDOMjudge:mainfrom
meisterT wants to merge 1 commit intoDOMjudge:mainfrom
Conversation
vmcj
reviewed
Feb 25, 2026
| exit(1) | ||
| else: | ||
| return do_api_request(name) | ||
| return do_api_request(name, method, jsonData, decode) |
Member
There was a problem hiding this comment.
I don´t see where we would generate the url with http but why would we want to fallback to http instead of doing HTTPS with an untrusted certificate?
Fix should work though, so approving.
vmcj
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.