Detect internal-error for submission before processing it#3483
Open
vmcj wants to merge 2 commits intoDOMjudge:mainfrom
Open
Detect internal-error for submission before processing it#3483vmcj wants to merge 2 commits intoDOMjudge:mainfrom
vmcj wants to merge 2 commits intoDOMjudge:mainfrom
Conversation
vmcj
force-pushed
the
internal_error_runguard
branch
2 times, most recently
from
ca2141b to
dab1ad6
Compare
meisterT
reviewed
Mar 1, 2026
vmcj
force-pushed
the
internal_error_runguard
branch
from
dab1ad6 to
4f8bf5d
Compare
By reading the code it looks like neither the runguard `internal-error` nor the Verdict::INTERNAL_ERROR was ever handled.
vmcj
force-pushed
the
internal_error_runguard
branch
from
4f8bf5d to
2cb4c7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By reading the code it looks like neither the runguard
internal-errornor theVerdict::INTERNAL_ERRORwas ever handled forprogram.meta.I've added the judgetaskid for the disabling, I'm not 100% if we need that information (or if it even will break something).